feat: add user lang cookie preference #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoa
force-pushed
the
dcoa/user-lang-pref-cookie
branch
from
cdff4be to
8c01f53
Compare
dcoa
force-pushed
the
dcoa/user-lang-pref-cookie
branch
from
8c01f53 to
ab40b63
Compare
MaferMazu
approved these changes
May 23, 2024
There was a problem hiding this comment.
Thanks for this. It's working as expected. Before this change, I tried to manually change the openedx-lang cookies, but the platform didn't take them into account; with this change, the platform takes into account the preferences I set in the cookies.
Thanks @dcoa 🙌
For future reference, I will let the initial problem here: https://github.com/openedx/edx-platform/blob/open-release/palm.master/openedx/core/djangoapps/lang_pref/middleware.py#L61-L62.
bra-i-am
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the intention to allow users to change the website language preference based on their cockies.
This PR is inspired by eduNEXT/eox-nelp#127 and allows the normal behavior of the header and footer lang selectors for Django templates.
https://edunext.atlassian.net/browse/DS-936